46 | | || TrueLoveProblems || Jonathan (contains uniform and rotating collapse) || |
47 | | || UniformCollapse || || |
| 46 | || TrueLoveProblems || Jonathan - will modify this to just be rotating collapse and leave separate uniform collapse dir || |
| 47 | || UniformCollapse || Jonathan || |
| 48 | |
| 49 | == Other thoughts == |
| 50 | * We will all have to make sure to not check in modified problem modules... |
| 51 | * And we should be careful about checking in modified data files. |
| 52 | * Please use the data files in the template directory and then modify them as necessary for each problem so that every problem has consistent clear documentation |
| 53 | * Also - if we want things to be runnable with gfortran - then we cannot have multiline variables in the data files... Or comment lines inside of a namelist. Not sure if this is something we care about or not. It is nice in physics.data to have full line comments in between various 'sections' for user readability... We could probably write a script for use with the gfortran compiler that would remove these lines - but it is more difficult to write a script that takes a multiline variable and shrinks it to one line. So we should probably avoid things like |
| 54 | {{{ |
| 55 | Gmx = 24, !cells in x direction |
| 56 | 24, !cells in y direction |
| 57 | 1 !cells in z direction |
| 58 | |
| 59 | }}} |
| 60 | |
| 61 | and instead do |
| 62 | |
| 63 | {{{ |
| 64 | Gmx = 24, 24, 1 !cells in [x,y,z] direction |
| 65 | }}} |
| 66 | |
| 67 | to make these data files as compatible as possible. |