Changes between Version 29 and Version 30 of u/erica/OutflowFeedback

Timestamp:

10/31/17 18:00:34 (7 years ago)

Author:

Erica Kaminski

Comment:

—

u/erica/OutflowFeedback

@@ -3 +3 @@
 The outflow module injects a fraction of accreted mass, momentum and angular momentum back into the grid following each accretion time step and between hydro advances.
 
-=== Feedback !Switches/Control ===
+'''Outflow Feedback Algorithm Outline'''
 
-To turn on 
+Feedback related variables are defined in &PhysicsData namelist (/src/physics/physics_control.f90). These include: 
+ 
+ iOutflowFeedback 
+
+ f_m 
+
+ outflow_radius
+
+ f_a 
+
+ opening_angle
+
+ outflow_temp 
+
+These get read in at runtime and used in the '!CollectNewParticles' subroutine (particle_comms.f90), where the particles are associated with these variable.
 
 
@@ -51 +65 @@
 Gets mass and momentum injection exact, but then guesses at angular momentum injection. At this step it can then mess up the linear momentum injection, which causes an iteration for the L again. This happens back and forth until some small error is achieved. Question -- under what circumstance does this fail? Something about discretization error in the routine, because the kernel is only 4 zones across?
 
-== Questions / Tests ==
+== Tests ==
 
-==== Are there any quantities that are stepped on each timestep in the kernel, or are quantities only summed/subtracted during injection/accretion steps? ====
+==== Angular Momentum Conservation b/w sink and gas ====
+
+==== Other flow variable conservation ====
+
+==== Correct outflow profile ====
+
+
+== Questions ==
+
+Q. Are there any quantities that are stepped on each timestep in the kernel, or are quantities only summed/subtracted during injection/accretion steps? 
 
 Thinking how does the flow change over time such that the kernel switches from infall to outflow.
 
-==== Is the amount of "push" in the outflow subject to resolution? ====
+Q.  Is the amount of "push" in the outflow subject to resolution? 
 
-==== When we remove gas from cells, do we need to apply a pressure to those cells (if not, do we see any artificial waves generated due to the sudden pressure loss in those cells?) ====
+Q.  When we remove gas from cells, do we need to apply a pressure to those cells (if not, do we see any artificial waves generated due to the sudden pressure loss in those cells?) 
 
-==== How is the Bondi speed used in the accretion module? ====
+Q.  How is the Bondi speed used in the accretion module? 
 
 If we can estimate the infall speed of the material around the sink as approaching the Bondi limit (is this simply pressureless collapse?), then when does $V_{out}$ >  ~ $f_a V_{bondi}$, where $f_a$ is the fraction of accreted mass to be injected in outflow. 
 
-==== Why do we conserve the center of mass (COM) of the system -- is it the location of the sink particle (if so, doesn't that coincide with the gravitational potential minimum?) ====
+Q.  Why do we conserve the center of mass (COM) of the system -- is it the location of the sink particle (if so, doesn't that coincide with the gravitational potential minimum?) 
 
 
-==== What is the spin angular momentum of the sink and how do we calculate it? ====
+Q. What is the spin angular momentum of the sink and how do we calculate it?
 
   
@@ -118 +141 @@
 Elliptic -> Hydro -> Particle -> Radiative?
 
-'''Outflow Feedback Algorithm Outline'''
-
-Feedback related variables are defined in &PhysicsData namelist (/src/physics/physics_control.f90). These include: 
- 
- iOutflowFeedback 
-
- f_m 
-
- outflow_radius
-
- f_a 
-
- opening_angle
-
- outflow_temp 
-
-These get read in at runtime and used in the '!CollectNewParticles' subroutine (particle_comms.f90), where the particles are associated with these variable.